Skip to content

Conversation

ceciliastevens
Copy link
Contributor

Description of Change

This adds a user guide to clarify how to use the code42 devices list and code42 devices bulk deactivate commands in combination. We've had several internal questions about how to do this and what the capabilities are over the past few days, so I wanted to get something added to the documentation.

I've added the guide, but I'm not sure if there needs to be a changelog update for documentation changes. Should I put a line there?

Please also feel free to make any edits or changes you feel are necessary or recommended to the guide, it's very much a first draft at the moment.

@github-actions
Copy link

github-actions bot commented Feb 26, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@alanag13
Copy link
Contributor

alanag13 commented Feb 26, 2021

Thanks! You do not need to include a changelog update for documentation changes, that's just for things that affect usage / functionality. I'm adding @annie-payseur to the review to give feedback on the docs.

Copy link
Contributor

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Some pretty small feedback

@@ -0,0 +1,65 @@
# Clean up your environment by deactivating devices

Your Code42 environment may contain many old devices that are no longer active computers, and that have not connected to Code42 in quite some time. In order to clean up your environment, you can use the CLI to deactivate these devices in bulk.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines are bit long - obviously only appears so in editors, but it doesn't hurt to put newlines in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some line breaks. It's pretty arbitrary at this point so we may want to move them around later.

Copy link
Contributor

@annie-payseur annie-payseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editorial suggestions.


The `code42 devices bulk deactivate` command will output the input
you gave it, plus a column indicating the success or failure of
the deactivation. To change the format of this output, use the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "...will output the input you gave it" seems confusing. That statement also seems to suggest you can use code42 devices bulk deactivate standalone, which you can't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rephrased this. The code42 devices bulk deactivate command can be used standalone, but it does need to be provided an input spreadsheet. The output is the guid plus an indication of whether or not the deactivation was successful, which hopefully the new wording communicates better.

@alanag13 alanag13 merged commit aac2684 into code42:master Mar 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
@ceciliastevens ceciliastevens deleted the deactivatedevice_guide branch March 3, 2021 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants